Proposed additions and changes to several utilities

[standtrooper]

These classes are my proposed additions with the exception of StringUtilities which contains my additions and removed several Date utilities and refactored them to DateUtil with some of my proposed additions.

[darkfrog]

Some of your code has me concerned:

Code:

public static String reverseLookupMonth(int month) {
        //the month returned is 1 based, the result we need is 0 based.
        int monthus = month - 1;

        String returner = null;

        for (int i = 0; i < DateUtility.MONTHS_INT.length; i++) {
            if (DateUtility.MONTHS_INT[i] == monthus) {
                returner = DateUtility.MONTHS_STR[i];
                break;
            }
        }

        return returner;
    }

Could that method simply be:

Code:

public static String reverseLookupMonth(int month) {
    month--;
    if ((DateUtility.MONTHS_STR.length < month) || (month < 0)) return null;
    return DateUtility.MONTHS_STR[month];
}

[standtrooper]

I'd be worried about that as well, but I'm pretty sure that's not my code, but the refactored code from StringUtilities.  I'll have a look, if it is mine, I'm going to have to go back through it all again.

[darkfrog]

Just looked in StringUtilities...it ain't mine.

[standtrooper]

ok, well, I don't remember writing that part either... and that has me really concerned!

I'll scrub the rest of the code and see if there's anything else in there that sucks ***. 

apologies for the code, I didn't think it was mine b/c before I added the files, I tried to add javadocs to all of my methods since I noticed that there weren't many, if any, in jcommons.

[darkfrog]

Well, jCommon hasn't really received much love...it's just my repository of stuff I've written that I can commonly use between applications I'm developing.  I put it out because friends/coworkers/etc had asked me to but I really haven't given it any time to "pretty it up" or even clean up the API.

[standtrooper]

that's how my java utilities is as well.  I was only commenting that I commented to distinguish the code I added from the code I refactored.   I figured that trying to add methods to existing classes or new classes I'm the only one that may understand and find what i'm looking for, so I'd add a small comment just to say briefly what it does.

[darkfrog]

I'm not even sure for the combat demo we'll be using jCommon, so at this point I don't really want to spend much time on jCommon, I'd rather be spending that time on "the other" endeavor.

[standtrooper]

I agree.  I was trying to refactor most, if not all, of gdju to jcommon cause I'm tired of managing so many projects... however, as you pointed out, there are definitely some sections of code that I didn't know about, didn't write or probably just copied from somewhere else to use as a temporary section of code.

I'll forego the additions for now, maybe come back to it some other time.